kungfub3s: replace BAD_DUMP sound ROM with one from another romset#15337
Conversation
Since there's no useful information at all
|
|
||
| ROM_REGION( 0x10000, "irem_audio:iremsound", 0 ) | ||
| ROM_LOAD( "3.bin", 0xa000, 0x2000, BAD_DUMP CRC(b4293435) SHA1(5e2b96c19c4f5c63a5afa2de504d29fe64a4c908) ) // Empty ROM | ||
| ROM_LOAD( "3.bin", 0xa000, 0x2000, NO_DUMP ) |
There was a problem hiding this comment.
Needs ROMREGION_ERASEFF to preserve current behaviour (the ROM is 1-filled).
Assuming we even want to do this, looks a YAGNI to me?
There was a problem hiding this comment.
I'm just trying to avoid false positives when looking for new dumps matches...
There was a problem hiding this comment.
The ROMREGION_ERASEFF fills not just the part where the dead ROM was, but also the unused part below 0xa000 with 0xff. Not sure if that’s desired. Does 0xff vs 0x00 in the dead ROM space really improve anything for the 6803?
|
May I suggest this instead:
|
Much better, thanks a lot |
happppp
changed the title
4 participants
Since there's no useful information at all